-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduced number of threads for finalizer removal to 1 #424
Reduced number of threads for finalizer removal to 1 #424
Conversation
Hi @Danil-Grigorev. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -61,6 +61,7 @@ var ( | |||
retryIntervalStart = flag.Duration("retry-interval-start", time.Second, "Initial retry interval of failed provisioning or deletion. It doubles with each failure, up to retry-interval-max.") | |||
retryIntervalMax = flag.Duration("retry-interval-max", 5*time.Minute, "Maximum retry interval of failed provisioning or deletion.") | |||
workerThreads = flag.Uint("worker-threads", 100, "Number of provisioner worker threads, in other words nr. of simultaneous CSI calls.") | |||
finalizerThreads = flag.Uint("cloning-protection-threads", 5, "Number of simultaniously running threads, handling cloning finalizer removal") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking even 1 may be sufficient as a default. Cloning shouldn't be that frequent?
/ok-to-test |
/ok-to-test |
9ced7b2
to
ca67001
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Danil-Grigorev, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
oh, please update the README! |
/lgtm |
…go_modules/k8s.io/client-go-0.26.3 Bump k8s.io/client-go from 0.26.2 to 0.26.3
What type of PR is this?
/kind flake
What this PR does / why we need it:
Follow up PR to #422, addressing comment - #422 (comment)
Special notes for your reviewer:
Does this PR introduce a user-facing change?: